CJCombrink commented on PR #3229: URL: https://github.com/apache/thrift/pull/3229#issuecomment-3500850262
@fishy Thanks for your inputs and review, I think I have addressed all feedback. I think we can merge, I propose leaving the [`BUILD_SHARED_LIBS: OFF`](https://github.com/apache/thrift/pull/3229/files#diff-92ab9a36df5d8e9f7076f2fdec59492d1ac2d9cf27ea046767a7fc4d542ef3dc) as part of this PR and then I will enable again as part of the fix for [THRIFT-5898](https://issues.apache.org/jira/browse/THRIFT-5898), that way at least Appveyor builds should stay green for any other PRs -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
