ctubbsii opened a new pull request, #2241:
URL: https://github.com/apache/zookeeper/pull/2241
Replace maven-antrun-plugin with better alternatives:
* Use build-helper-maven-plugin for keeping versions up-to-date in cclient
code
* Use build-helper-maven-plugin for retrieving hostname
* Use Maven native `env.*` properties instead of antrun
* Simplify maven-release-plugin to remove extra commit (versions should
already be up-to-date from previous SNAPSHOT builds during development)
* Use exec-maven-plugin for calling make
* Use maven-resources-plugin for creating empty working directory
* Use maven-resources-plugin for injecting the version into the cclient
files (without the `-SNAPSHOT` suffix)
* [BUGFIX] Fixes the incorrect pattern matching of version in
`zookeeper_version.h`
Additionally, perform some minor cleanup of modified files:
* Fix xml indentations in modified pom.xml files
* Use `${project.build.directory}` property instead of target when possible
* [BUGFIX] Fix some paths that used semi-colons as the path separator and
use the OS-dependent path separator
This fixes a few bugs (see above notes).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
