kezhuw commented on code in PR #2241: URL: https://github.com/apache/zookeeper/pull/2241#discussion_r2078796637
########## zookeeper-client/zookeeper-client-c/src/main/c-filtered/include/zookeeper_version.h: ########## @@ -0,0 +1,31 @@ +/** Review Comment: > My preference would be to have the build set up something in /target for the c build to work out of... that way all the Java build stuff can modify these files in the target directory, rather than in the src tree. But this PR was supposed to be a small change, not a big sweeping one. I support all of above, but the result of this pr make things worse from my point of view. Before this pr, the thing is that those files are tracked in place and we need one compilation phase to change their content. After this pr, these files are replaced in compilation and people have to filter out sources of these files to make change to take effect. This costs extra efforts. I would like to limit these source files to be only version related so we have no chance to touch them. > Those files that are changed are already tracked. If those files are only version related, I don't see much of value to be tracked. But I am ok to both, tracked or not. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
