ctubbsii commented on code in PR #2241: URL: https://github.com/apache/zookeeper/pull/2241#discussion_r2080357479
########## zookeeper-client/zookeeper-client-c/src/main/c-filtered/include/zookeeper_version.h: ########## @@ -0,0 +1,31 @@ +/** Review Comment: @kezhuw The logic at https://github.com/apache/zookeeper/blob/master/zookeeper-client/zookeeper-client-c/configure.ac#L69-L74 suggests that there is a desire to support running these commands without running Maven first. If we stop tracking the generated file, or remove it, devs will be required to run Maven first before running outside Maven. Is that okay? Is that better? Currently, they only need to run the Maven build to recreate those files if the version changes, or if other changes are made in the source templates I made in `src/main/c-filtered/`; if we remove these files and stop tracking them, then dev will be required to always run Maven first. Would a good compromise be to add a comment to the files saying this: `This is a generated file. If you are a developer, make changes to the template file in src/main/c-filtered` ? Or is it still better to just remove the files and stop tracking them? (and maybe also add the comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
