ctubbsii commented on code in PR #2241: URL: https://github.com/apache/zookeeper/pull/2241#discussion_r2054857130
########## zookeeper-client/zookeeper-client-c/src/main/c-filtered/include/zookeeper_version.h: ########## @@ -0,0 +1,31 @@ +/** Review Comment: No, these shouldn't change in the build. They are copied into place with substitutions. Those files that are changed are already tracked. My preference would be to have the build set up something in /target for the c build to work out of... that way all the Java build stuff can modify these files in the target directory, rather than in the src tree. But this PR was supposed to be a small change, not a big sweeping one. So, I just made templates that are checked in to automatically modify the ones that they edit that are already checked in. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
