kezhuw commented on code in PR #2241: URL: https://github.com/apache/zookeeper/pull/2241#discussion_r2083382053
########## zookeeper-client/zookeeper-client-c/src/main/c-filtered/include/zookeeper_version.h: ########## @@ -0,0 +1,31 @@ +/** Review Comment: > The logic at https://github.com/apache/zookeeper/blob/master/zookeeper-client/zookeeper-client-c/configure.ac#L69-L74 suggests that there is a desire to support running these commands without running Maven first. If we stop tracking the generated file, or remove it, devs will be required to run Maven first before running outside Maven. Is that okay? Is that better? Thank you for point out this! I think it is a good to make build of c client independent. I found [installation guide](https://zookeeper.apache.org/doc/r3.9.3/zookeeperProgrammers.html#C+Binding) for c binding. I would say it is good and let's don't change it. Currently, this pr require additional maven build for changes in cmake/automake files. I don't think it is worth for us to go this direction. > Does https://github.com/apache/zookeeper/commit/b52ad0a152c2b7c4086b82ac4bdbb62f345fb7a0 address your concerns? Sorry for my rollback! I don't think the extra maven build is good for c client. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@zookeeper.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
