Hi Tomek I believe that benchmarks in oak-run also use Jackrabbit 2 (via fixtures). However, OAK-3342 proposes moving the benchmarks into their own module.
Looking at this from a less technical perspective, I propose to split oak-run into three modules: - oak-dev-tools (benchmarks, scalability, etc), size does not matter so much, as devs probably build it themselves - oak-upgrade (all things copying repositories between persistence formats), contains JR2 - oak-ops-tools (tools used for operating an Oak repo: inspecting, checking, console, etc. may also contain NodeStore copy for convenience if code duplication can be avoided), does NOT contain JR2 Naming is of course up for debate. Let's just discuss if a split along these lines makes sense for now. WDYT? Regards Julian On Wednesday, September 2, 2015, Tomek Rekawek <[email protected]> wrote: > Hi, > > One more thing. The “upgrade" command requires a lot of Maven dependencies > (Amazon API client for the S3 support, Jackrabbit 2 for the repository > upgrades, etc.) Some of these dependencies conflicts with the Oak modules > (eg. Jackrabbit 2 uses older lucene-core than the oak-lucene and the new > version is not backward-compatible). Because of that, the dependency > management in the oak-run module is complicated - even before my patch > there is a separate profile for building the project using Jackrabbit 2 > dependencies and there are also two assembly files building the normal jar > and the “jackrabbit 2” jar. > > I think we should extract the upgrade command to a separate Maven module > (eg. oak-migrator or oak-upgrade-tool). This way we can precisely define > what are the required dependencies and we don’t need to care if they are > compatible with other oak-run commands. > > Any objections? :) > > Best regards, > Tomek > > > On 02/09/15 14:58, "Tomek Rekawek" <[email protected]> wrote: > > >Hello, > > > >I created a pull request [1] for the OAK-2171 [2]. It exposes all > features added recently to the oak-upgrade module (version history copy, > filtering paths) as well as all migration paths (eg. mongo -> rdb) in the > oak-run upgrade command. There are also tests. Looking forward to feedback > :) > > > >Best regards, > >Tomek > > > >[1] https://github.com/apache/jackrabbit-oak/pull/38 > >[2] https://issues.apache.org/jira/browse/OAK-2171 > > > >-- > >Tomek Rękawek | Adobe Research | www.adobe.com > >[email protected] > > > > > > >
