rishabhdaim commented on code in PR #2936:
URL: https://github.com/apache/jackrabbit-oak/pull/2936#discussion_r3369603137
##########
oak-auth-external/src/test/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/ExternalLoginModuleFactoryTest.java:
##########
@@ -213,6 +214,32 @@ public void testMBeanRegistrationAlreadyPresent() throws
Exception {
assertSame(mbeanregistration, getMBeanRegistration());
}
+ @Test
Review Comment:
`setUpJaasFactoryWithInjection` (line ~107) registers Repository,
SyncManager, and ExternalIdentityProviderManager but not
`ExternalIdentityMonitor`.
`testSyncCreateUser` therefore still exercises the legacy per-login
whiteboard track path, not the factory pre-injection path this PR adds.
Register `ExternalIdentityMonitor` (or a mock) there so the integration test
matches this new test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
