joerghoh commented on code in PR #2936:
URL: https://github.com/apache/jackrabbit-oak/pull/2936#discussion_r3369834580
##########
oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/ExternalLoginModuleFactory.java:
##########
@@ -149,18 +153,29 @@ public ExternalLoginModuleFactory(
this.syncManager = syncManager;
this.idpManager = idpManager;
+ // TODO: context cannot be null, but tests are invoked with this being
null. Tests should
+ // be adjusted accordingly, and then all these implicit and explicit
null checks should be removed.
this.osgiConfig = Optional.ofNullable(context)
.map(ctx -> ConfigurationParameters.of(ctx.getProperties()))
.orElse(ConfigurationParameters.EMPTY);
this.bundleContext =
Optional.ofNullable(context).map(ComponentContext::getBundleContext).orElse(null);
+ if (this.bundleContext != null) {
+ monitorTracker = new ServiceTracker<>(this.bundleContext,
ExternalIdentityMonitor.class, null);
+ monitorTracker.open();
+ }
+
mayRegisterSyncMBean();
}
@SuppressWarnings("UnusedDeclaration")
@Deactivate
private void deactivate() {
unregisterSyncMBean();
+ if (monitorTracker != null) {
Review Comment:
With switching to SCR this is no longer required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
