rishabhdaim commented on code in PR #2936:
URL: https://github.com/apache/jackrabbit-oak/pull/2936#discussion_r3369602118
##########
oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/ExternalLoginModuleFactory.java:
##########
@@ -29,6 +29,8 @@
import org.apache.jackrabbit.oak.spi.security.SecurityProvider;
import
org.apache.jackrabbit.oak.spi.security.authentication.external.ExternalIdentityProviderManager;
import
org.apache.jackrabbit.oak.spi.security.authentication.external.SyncManager;
+import
org.apache.jackrabbit.oak.spi.security.authentication.external.impl.monitor.ExternalIdentityMonitor;
+import org.osgi.util.tracker.ServiceTracker;
Review Comment:
nits: `org.osgi.util.tracker.ServiceTracker` sits between Oak security
imports; group it with the other `org.osgi` imports below.
##########
oak-auth-external/src/main/java/org/apache/jackrabbit/oak/spi/security/authentication/external/impl/ExternalLoginModuleFactory.java:
##########
@@ -245,6 +260,11 @@ public LoginModule createLoginModule() {
ExternalLoginModule lm = new ExternalLoginModule(osgiConfig);
lm.setIdpManager(idpManager);
lm.setSyncManager(syncManager);
+ // TODO: the monitorTracker cannot be null either (see the TODO in the
c'tor)
+ ExternalIdentityMonitor monitor = monitorTracker != null ?
monitorTracker.getService() : null;
+ if (monitor != null) {
+ lm.setMonitor(monitor);
+ }
return lm;
}
Review Comment:
nits: this file is missing the trailing newline at EOF.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
