[ 
https://issues.apache.org/jira/browse/OAK-709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13622079#comment-13622079
 ] 

Michael Dürig commented on OAK-709:
-----------------------------------

Good stuff! To get the move and observation test in {{RepositoryTest}} to pass 
I needed to:
{code}
===================================================================
--- 
oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/AbstractNodeState.java
   (date 1365077783000)
+++ 
oak-core/src/main/java/org/apache/jackrabbit/oak/spi/state/AbstractNodeState.java
   (revision )
@@ -102,7 +102,7 @@
             String name = beforeCNE.getName();
             NodeState beforeChild = beforeCNE.getNodeState();
             NodeState afterChild = getChildNode(name);
-            if (afterChild == null) {
+            if (!afterChild.exists()) {
                 diff.childNodeDeleted(name, beforeChild);
             } else {
                 baseChildNodes.add(name);
{code}

Didn't run the full integration tests yet but this might well be just an 
oversight.
                
> Consider moving permission evaluation to the node state level
> -------------------------------------------------------------
>
>                 Key: OAK-709
>                 URL: https://issues.apache.org/jira/browse/OAK-709
>             Project: Jackrabbit Oak
>          Issue Type: Sub-task
>          Components: core
>            Reporter: angela
>         Attachments: 
> 0001-OAK-709-Consider-moving-permission-evaluation-to-the.patch, 
> 0001-OAK-709-Consider-moving-permission-evaluation-to-the.patch, 
> 0001-OAK-709-Consider-moving-permission-evaluation-to-the.patch, 
> OAK-709.patch, SecureNodeState.java
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to