[
https://issues.apache.org/jira/browse/OAK-709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13623485#comment-13623485
]
Michael Dürig commented on OAK-709:
-----------------------------------
Looking at OAK-709_2.patch I found two things:
# {{RootImpl.rebase}} should also reset the root tree to the secure head
instead of the head of the branch. This is probably just and oversight.
# The performance regression in {{LargeMoveTestIt}} is caused by
{{SecureNodeState}} not providing an efficient implementation for {{equals}}.
In order for such a method to be actually used it might be necessary to also
tweak the {{equals}} implementation of other {{NodeState}} implementations.
[~jukkaz] might shed some more light on this.
> Consider moving permission evaluation to the node state level
> -------------------------------------------------------------
>
> Key: OAK-709
> URL: https://issues.apache.org/jira/browse/OAK-709
> Project: Jackrabbit Oak
> Issue Type: Sub-task
> Components: core
> Reporter: angela
> Attachments:
> 0001-OAK-709-Consider-moving-permission-evaluation-to-the.patch,
> 0001-OAK-709-Consider-moving-permission-evaluation-to-the.patch,
> 0001-OAK-709-Consider-moving-permission-evaluation-to-the.patch,
> 0001-OAK-709-Consider-moving-permission-evaluation-to-the.patch,
> OAK-709_2.patch, OAK-709.patch, SecureNodeState.java
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
