[ 
https://issues.apache.org/jira/browse/OAK-709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13623497#comment-13623497
 ] 

Jukka Zitting commented on OAK-709:
-----------------------------------

As noted in OAK-753, I'd prefer if the isHidden() check was included in 
SecureNodeState instead of applied on top of it in TreeImpl.

bq. efficient implementation for equals

... or alternatively/additionally, add an optimization that skips the 
SecureNodeState wrapper for such subtrees (or leaf nodes) where the user has 
full read access. In most normal cases the majority of nodes in a repository 
only inherit access settings from their ancestors and have no direct ACL 
settings on themselves or any of their descendants. Such nodes should *not* 
have SecureNodeState wrappers.
                
> Consider moving permission evaluation to the node state level
> -------------------------------------------------------------
>
>                 Key: OAK-709
>                 URL: https://issues.apache.org/jira/browse/OAK-709
>             Project: Jackrabbit Oak
>          Issue Type: Sub-task
>          Components: core
>            Reporter: angela
>         Attachments: 
> 0001-OAK-709-Consider-moving-permission-evaluation-to-the.patch, 
> 0001-OAK-709-Consider-moving-permission-evaluation-to-the.patch, 
> 0001-OAK-709-Consider-moving-permission-evaluation-to-the.patch, 
> 0001-OAK-709-Consider-moving-permission-evaluation-to-the.patch, 
> OAK-709_2.patch, OAK-709_3.patch, OAK-709-equals_hack.patch, OAK-709.patch, 
> SecureNodeState.java
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to