On Sun, May 16, 2010 at 04:24:12AM +1200, Ralph Versteegen wrote: > On 15 May 2010 20:55, James Paige <[email protected]> wrote: > > On Sat, May 15, 2010 at 01:51:54AM -0700, [email protected] > > wrote: > >> james > >> 2010-05-15 01:51:54 -0700 (Sat, 15 May 2010) > >> 140 > >> Replace stat(,,) array with some reasonably sane type objects. > >> Yay! No longer need to pass stat() to a bunch of various subs and > >> functions! > >> --- > > > > I think I tested this one out pretty well, but it touches a lot of lines > > in a lot of files, so if anybody notices anything strange with stats, > > please speak up! > > > > --- > > James > > Ah, that's some very nice cleanup :) It looks like we are now doing > almost no passing around of global data! > > Regarding adding more stats in future, there's no need to number the > stat: constants consecutively. I think we could internally number > stats consecutively, and have a tiny little bit of code in > get/setherostat and the enemy stat commands to treat stats 12 and 13 > specially, and subtract 2 for stats >= 14.
Good point! Right now, the high stats on the map have pic/pal/level data, and the high stats in battle have affliction registers, but I can move all of those. That means that the only places that need to know about those irregularities are the get/set hero stat commands and the attack target stat code respectively. --- James _______________________________________________ Ohrrpgce mailing list [email protected] http://lists.motherhamster.org/listinfo.cgi/ohrrpgce-motherhamster.org
