simgunz added a comment.
In D15580#553421 <https://phabricator.kde.org/D15580#553421>, @ngraham wrote: > All right, that works! > > I think there's only one remaining thing I noticed, then I'm ready to give it a UI stamp of approval: the toolbar should have a close button on the far-right side (you can use an expanding spacer to position it there) so people don't have to go up to the menubar to close the toolbar once they're done using it. I have never seen a close button on a standard toolbar. Are you sure it is a correct design pattern? There are cases where the close button might be misleading given the configurability of the toolbars. F7669753: Screenshot_20191025_210846.png <https://phabricator.kde.org/F7669753> //Annotation toolbar in the same row as the main toolbar. There is not distinction between the two, so it is not clear what the close button applies to.// F7669750: Screenshot_20191025_211307.png <https://phabricator.kde.org/F7669750> //Having the button right aligned may put it in a weird position when the window is maximized.// ------ Regarding the HIG guidelines <https://hig.kde.org/components/navigation/toolbar.html>. We are currently violating the following two rules 1. Don’t change the button style from the default, which is text beside icons. 2. Don’t hide toolbars by default. If a toolbar can be hidden, users should easily be able to make the toolbar viewable again. Is this fine? My opinion: 1. Don't care much. "Icon-only" is fine for me. 2. I think it makes sense to hide it by default. It is consistent with the current Okular behavior, so users that are used to the current toolbar will find no difference. ----- Now the default is "icon-only". If a user changes to "text alongside icons" the toolbar will overflow even on a large monitor. Should I configure the toolbar so that if the user changes to "text alongside icons" the toolbar appears like this? (the user can then expand the remaining icon-only buttons one by one by right clicking on them if he needs to visualize the text) F7670023: Screenshot_20191025_222139.png <https://phabricator.kde.org/F7670023> //Non-obvious actions expanded, obvious one compressed.// REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D15580 To: simgunz, #okular, #vdg Cc: trickyricky26, simgunz, ltoscano, cfeck, aacid, davidhurka, knambiar, ngraham, tobiasdeiminger, okular-devel, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen
