simgunz added a comment.
>> I think there's only one remaining thing I noticed, then I'm ready to give it a UI stamp of approval: the toolbar should have a close button on the far-right side (you can use an expanding spacer to position it there) so people don't have to go up to the menubar to close the toolbar once they're done using it. > I have never seen a close button on a standard toolbar. Are you sure it is a correct design pattern? One more thing regarding this. kpartgui.dtd does not have a "spacer" item. So that and the close action should be inserted programmatically with some non-so-nice code to retrieve the annotation toolbar (see https://phabricator.kde.org/D15580#544534). @davidhurka I am going to reply to your comments Sunday REPOSITORY R223 Okular REVISION DETAIL https://phabricator.kde.org/D15580 To: simgunz, #okular, #vdg Cc: trickyricky26, simgunz, ltoscano, cfeck, aacid, davidhurka, knambiar, ngraham, tobiasdeiminger, okular-devel, johnzh, andisa, siddharthmanthan, maguirre, fbampaloukas, joaonetto, kezik, tfella, darcyshen