> On 2012-03-28 19:47:57, Alejandro Abdelnur wrote: > > I think my previous comment on the WFApp not checking the supported > > filesystems was not fully understood. > > > > We should check that the app path is for a supported filesystem and fail if > > not. else people could write WFs in the local filesystem or NFS and loaded > > from Oozie. This should be possible only if it is a supported filesystem
added the Wf app path check. To avoid code repetition, defined this logic of "checkSupportedFilesystem" in parent class ActionExecutor and invoking from JavaAE and FsAE. Modified/added respective testcases. > On 2012-03-28 19:47:57, Alejandro Abdelnur wrote: > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java, > > line 358 > > <https://reviews.apache.org/r/2059/diff/8/?file=97129#file97129line358> > > > > this should be done once, if supportedSchemes is null. it should be > > done within a synchronized block: > > > > synch { > > if (supportedSchemes == null) { > > ///load > > } > > } > > > > this would create minimum contention as there is no logic at all after > > the first pass that loads the supported schemes done - Mona ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2059/#review6487 ----------------------------------------------------------- On 2012-03-28 00:14:46, Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2059/ > ----------------------------------------------------------- > > (Updated 2012-03-28 00:14:46) > > > Review request for oozie, Mohammad Islam and Angelo K. Huang. > > > Summary > ------- > > This patch was originally worked on by Mayank Bansal. > I (Mona Chitnis) am in charge of handling this review request. > > Description - adding hadoop.next support for oozie > > > This addresses bug OOZIE-477. > https://issues.apache.org/jira/browse/OOZIE-477 > > > Diffs > ----- > > trunk/client/src/main/java/org/apache/oozie/client/XOozieClient.java > 1303609 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java > 1303609 > trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java > 1303609 > trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java > 1303609 > trunk/core/src/main/resources/oozie-default.xml 1303609 > > trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java > 1303609 > > Diff: https://reviews.apache.org/r/2059/diff > > > Testing > ------- > > tested against current unit tests > > > Thanks, > > Mona > >
