> On 2012-03-27 20:14:21, Alejandro Abdelnur wrote: > > The check for supported FS schemes should also be done in the submission of > > the WF/COORD/BUNDLE job, no?
Yes thats right. As I replied to your earlier comment, there can be other places too, in addition to JavaActionExecutor where code change is required for federation. I am going to address that requirement in another JIRA OOZIE-782. This JIRA will be only to remove the hardcoding of "hdfs://" > On 2012-03-27 20:14:21, Alejandro Abdelnur wrote: > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java, > > line 1091 > > <https://reviews.apache.org/r/2059/diff/7/?file=96447#file96447line1091> > > > > this seems like a complete different thing from enabling different > > filesystem schemes. we should do this as part of a different JIRA Moving this out of this JIRA and into OOZIE-782 > On 2012-03-27 20:14:21, Alejandro Abdelnur wrote: > > trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java, > > line 248 > > <https://reviews.apache.org/r/2059/diff/7/?file=96449#file96449line248> > > > > (String) casting is not required done - Mona ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2059/#review6442 ----------------------------------------------------------- On 2012-03-27 00:15:40, Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2059/ > ----------------------------------------------------------- > > (Updated 2012-03-27 00:15:40) > > > Review request for oozie, Mohammad Islam and Angelo K. Huang. > > > Summary > ------- > > This patch was originally worked on by Mayank Bansal. > I (Mona Chitnis) am in charge of handling this review request. > > Description - adding hadoop.next support for oozie > > > This addresses bug OOZIE-477. > https://issues.apache.org/jira/browse/OOZIE-477 > > > Diffs > ----- > > trunk/client/src/main/java/org/apache/oozie/client/XOozieClient.java > 1303609 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java > 1303609 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 1303609 > trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java > 1303609 > trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java > 1303609 > trunk/core/src/main/resources/oozie-default.xml 1303609 > > trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java > 1303609 > > Diff: https://reviews.apache.org/r/2059/diff > > > Testing > ------- > > tested against current unit tests > > > Thanks, > > Mona > >
