----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2059/#review6513 -----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java <https://reviews.apache.org/r/2059/#comment14168> wasn't this going to be addressed by another JIRA? trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java <https://reviews.apache.org/r/2059/#comment14169> the synchronization cannot be on the current action instance as actions are created every time they are needed. the synchronization should be on something global, ie the class hosting this method trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java <https://reviews.apache.org/r/2059/#comment14170> again, this is suppose to be part of another JIRA, no? trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java <https://reviews.apache.org/r/2059/#comment14171> this code is duplicated in FSActionExecutor, it seems it should be factored out and reused. Furthermore, should this be loaded then by the ActionExecutor class itself? trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java <https://reviews.apache.org/r/2059/#comment14172> what am i missing? i still don't see the scheme being check here. - Alejandro On 2012-03-29 10:29:06, Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2059/ > ----------------------------------------------------------- > > (Updated 2012-03-29 10:29:06) > > > Review request for oozie, Mohammad Islam and Angelo K. Huang. > > > Summary > ------- > > This patch was originally worked on by Mayank Bansal. > I (Mona Chitnis) am in charge of handling this review request. > > Description - adding hadoop.next support for oozie > > > This addresses bug OOZIE-477. > https://issues.apache.org/jira/browse/OOZIE-477 > > > Diffs > ----- > > > trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java > 1303609 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java > 1303609 > trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java > 1303609 > trunk/core/src/main/resources/oozie-default.xml 1303609 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFsActionExecutor.java > 1303609 > trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java > 1303609 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 1303609 > trunk/client/src/main/java/org/apache/oozie/client/XOozieClient.java > 1303609 > trunk/core/src/main/java/org/apache/oozie/action/ActionExecutor.java > 1303609 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java > 1303609 > > Diff: https://reviews.apache.org/r/2059/diff > > > Testing > ------- > > tested against current unit tests > > > Thanks, > > Mona > >
