> On 2012-03-29 10:42:44, Alejandro Abdelnur wrote: > > trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java, > > line 153 > > <https://reviews.apache.org/r/2059/diff/9/?file=97338#file97338line153> > > > > what am i missing? i still don't see the scheme being check here. > > Mona Chitnis wrote: > Wouldn't the checking in respective action executors suffice ?
we should use the same scheme check to enforce where Oozie apps (XMLs) can be read from. Not only for WFs but for COORDs and BUNDLEs - Alejandro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/2059/#review6513 ----------------------------------------------------------- On 2012-03-29 10:29:06, Mona Chitnis wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/2059/ > ----------------------------------------------------------- > > (Updated 2012-03-29 10:29:06) > > > Review request for oozie, Mohammad Islam and Angelo K. Huang. > > > Summary > ------- > > This patch was originally worked on by Mayank Bansal. > I (Mona Chitnis) am in charge of handling this review request. > > Description - adding hadoop.next support for oozie > > > This addresses bug OOZIE-477. > https://issues.apache.org/jira/browse/OOZIE-477 > > > Diffs > ----- > > > trunk/core/src/test/java/org/apache/oozie/service/TestLiteWorkflowAppService.java > 1303609 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java > 1303609 > trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java > 1303609 > trunk/core/src/main/resources/oozie-default.xml 1303609 > > trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestFsActionExecutor.java > 1303609 > trunk/core/src/main/java/org/apache/oozie/action/hadoop/LauncherMapper.java > 1303609 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java > 1303609 > trunk/client/src/main/java/org/apache/oozie/client/XOozieClient.java > 1303609 > trunk/core/src/main/java/org/apache/oozie/action/ActionExecutor.java > 1303609 > > trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java > 1303609 > > Diff: https://reviews.apache.org/r/2059/diff > > > Testing > ------- > > tested against current unit tests > > > Thanks, > > Mona > >
