[ 
https://issues.apache.org/jira/browse/OOZIE-942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13430714#comment-13430714
 ] 

Virag Kothari commented on OOZIE-942:
-------------------------------------

I used the following and conf.size() returned 1. 
{code}
Configuration conf = new Configuration(false);
conf.set("", "planet");
String str = "<root xmlns=\"uri:oozie:workflow:0.4\"><parameters>"
                + "<property><name></name></property>"
                + "</parameters></root>";
ParameterVerifier.verifyParameters(conf, XmlUtils.parseXml(str));
assertEquals(1, conf.size());
assertEquals("planet", conf.get(""));
{code}
I think you are missing that there are two assertequals for conf.size() in 
testVerifyParametersDefined(). 

Yes, its better to have a new error for an empty name.

                
> Add formal Parameters to bundle XML
> -----------------------------------
>
>                 Key: OOZIE-942
>                 URL: https://issues.apache.org/jira/browse/OOZIE-942
>             Project: Oozie
>          Issue Type: Improvement
>            Reporter: Robert Kanter
>            Assignee: Robert Kanter
>         Attachments: OOZIE-942.patch
>
>
> Just like OOZIE-239 but add formal parameters to Bundle jobs too.  
> There's also a minor bug in OOZIE-239 that will prevent Oozie from printing a 
> warning when a user submits a coordinator job using schema >= 0.4 without a 
> <parameters> section.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to