Thank you for explanation Luis. I missed step 3 when I was going through test report. At least now I know where to search for issue and after this last one will be fixed, single layer model implementation will be finally finished, because other than this it is not causing any more regressions both with flag turned off and on, at least CSIT tests are not reporting any more regressions.
Regards, Tomas ________________________________________ Od: Luis Gomez [ece...@gmail.com] Odoslané: 16. februára 2017 18:51 Komu: Tomáš Slušný Kópia: openflowplugin-dev Predmet: Re: [openflowplugin-dev] Test feedback Hi Tomas, The reconciliation test does the following: 0) Enable stale-flow entry feature (otherwise step 5 will not work) 1) add 2000 groups + 1000 flows (+10 table-miss) 2) Disconnect network 3) Remove 20 groups + 10 flows 4) Reconnect network 5) Check groups and flows are deleted from switch (total: 1980 groups + 1000 flows) So what happens with your patch is that the flows (10) are being removed but the groups (20) are not, so somehow your patch creates regression on the stale-flow entry feature. BR/Luis > On Feb 16, 2017, at 6:57 AM, Tomáš Slušný <tomas.slu...@pantheon.tech> wrote: > > Hi again Luis, > > I managed to get single layer serialization to pretty stable state, but I > have 1 quick question, and hopefully you will know the answer. > > According to test result from flow-services CSIT here: > https://logs.opendaylight.org/releng/jenkins092/openflowplugin-csit-1node-flow-services-only-carbon/512/archives/log.html.gz > my patch is causing 2 regressions, and that is not correct count of groups > after mininet and controller restart. If I understand this right, in that > test, we are first sending > group 1 100 times to each of 10 switches, and then group 2 100 times to each > of 10 switches, so that in total makes 2000 groups that should be present. > And here is my question. > The CSIT tests is checking that 1980 groups should be present, and it was > passing before, but on my changes, I have all 2000 groups present. So, is > there reason, why we are > expecting there to have 20 groups missing? > > Regards. > Tomas > > ________________________________________ > Od: Tomáš Slušný [tomas.slu...@pantheon.tech] > Odoslané: 12. februára 2017 10:39 > Komu: Luis Gomez > Kópia: openflowplugin-dev > Predmet: Re: [openflowplugin-dev] Test feedback > > Thank you for testing it Luis. > > 1) I sort of expected this, because it was a lot of code and there was a lot > possibilities for mistakes. I need to double check all serializers and > deserializers again. > 2) Thank you for pointing this out, I missed the config parameter that tells > to skip collecting table features when rewriting device initialization > logic. > ________________________________________ > Od: Luis Gomez [ece...@gmail.com] > Odoslané: 11. februára 2017 2:48 > Komu: Tomáš Slušný > Kópia: openflowplugin-dev > Predmet: Re: [openflowplugin-dev] Test feedback > > Tomas, > > 1) New path enabled looks far from ready, I see too many regressions: lack of > switch info in inventory, flows not being pushed, stats not reported, among > other things. > > https://logs.opendaylight.org/releng/jenkins092/openflowplugin-csit-1node-flow-services-only-carbon/494/archives/log.html.gz > > 2) With path disabled I see you are bringing all the table features back so > its takes very long to update inventory, topology and register the connection: > > https://logs.opendaylight.org/releng/jenkins092/openflowplugin-csit-1node-flow-services-only-carbon/492/archives/log.html.gz#s1-s1-s1 > https://logs.opendaylight.org/releng/jenkins092/openflowplugin-csit-3node-clustering-only-carbon/480/archives/log.html.gz#s1-s1 > > Please let me know if I can help with anything else. > > On Feb 9, 2017, at 11:35 AM, Tomáš Slušný > <tomas.slu...@pantheon.tech<mailto:tomas.slu...@pantheon.tech>> wrote: > > Hi Luis, > > this is gerrit link for model cleanup (serialization of openflowplugin models > directly) https://git.opendaylight.org/gerrit/#/c/51304/. > It needs to be tested with new path disabled for regressions, and also with > new path enabled. > New path can be enabled/disabled with use-single-layer serialization flag in > openflow-plugin-provider-config YANG: > https://git.opendaylight.org/gerrit/#/c/50819/8/openflowplugin-api/src/main/yang/openflow-provider-config.yang > > Regards, > Tomas Slusny > > ________________________________________ > Od: Luis Gomez [ece...@gmail.com] > Odoslané: 9. februára 2017 19:28 > Komu: openflowplugin-dev > Predmet: [openflowplugin-dev] Test feedback > > Hi all, > > Infrastructure seems to be recovered from last days issues, please send me > the gerrit # that require full system test verification. > > FYI I already tried the switch connection patch [1] and got some failures in > the entity owner test [2] I have to investigate further and come back to you. > > Also as I commented this morning, lately I see a very often issue of switch > not getting table miss flow when it connects to 3 cluster nodes [3]. I will > try to reproduce issue and open bug. > > BR/Luis > > [1] https://git.opendaylight.org/gerrit/#/c/51500 > [2] > https://logs.opendaylight.org/releng/jenkins092/openflowplugin-csit-3node-clustering-only-carbon/474/archives/log.html.gz > [3] > https://logs.opendaylight.org/releng/jenkins092/openflowplugin-csit-3node-clustering-only-carbon/469/archives/log.html.gz > > _______________________________________________ > openflowplugin-dev mailing list > openflowplugin-dev@lists.opendaylight.org > https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev > > TomášSlušný > Software Developer > > Sídlo / Mlynské Nivy 56 / 821 05 Bratislava / Slovakia > R&D centrum / Janka Kráľa 9 / 974 01 Banská Bystrica / Slovakia > +421 911 083 902 / tomas.slu...@pantheon.tech > reception: +421 2 206 65 114 / www.pantheon.tech > > [logo] > > > > > TomášSlušný > Software Developer > > Sídlo / Mlynské Nivy 56 / 821 05 Bratislava / Slovakia > R&D centrum / Janka Kráľa 9 / 974 01 Banská Bystrica / Slovakia > +421 911 083 902 / tomas.slu...@pantheon.tech > reception: +421 2 206 65 114 / www.pantheon.tech > > [logo] > > > _______________________________________________ > openflowplugin-dev mailing list > openflowplugin-dev@lists.opendaylight.org > https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev TomášSlušný Software Developer Sídlo / Mlynské Nivy 56 / 821 05 Bratislava / Slovakia R&D centrum / Janka Kráľa 9 / 974 01 Banská Bystrica / Slovakia +421 911 083 902 / tomas.slu...@pantheon.tech reception: +421 2 206 65 114 / www.pantheon.tech [logo] _______________________________________________ openflowplugin-dev mailing list openflowplugin-dev@lists.opendaylight.org https://lists.opendaylight.org/mailman/listinfo/openflowplugin-dev
