On Fri, 20 Nov 2020 15:26:15 GMT, Nir Lisker <nlis...@openjdk.org> wrote:
>> The change looks reasonable to me, but since I don't use Eclipse it would be >> better for someone who does to review. >> @nlisker can you review this? > > Yes, but that's a problem of no reviewers. If I submit it myself then there > will also be no one to review. @kevinrushforth What do we do? I think that > previously when I updated the Eclipse files, there's wasn't a thorough review. In this case, it seems to me that it would be a quick win to accept the PR as it is now. In general, I'm not sure the IDE files really belong in the code repository, but since they are there, it is better to fix them. I don't use Eclipse, so I can't test. But if the part that is dealt with here is confirmed to work, I suggest we merge that, and create a follow-up issue for the missing parts (test). ------------- PR: https://git.openjdk.java.net/jfx/pull/352
