On Fri, 20 Nov 2020 15:44:57 GMT, Johan Vos <j...@openjdk.org> wrote:
>> Yes, but that's a problem of no reviewers. If I submit it myself then there >> will also be no one to review. @kevinrushforth What do we do? I think that >> previously when I updated the Eclipse files, there's wasn't a thorough >> review. > > In this case, it seems to me that it would be a quick win to accept the PR as > it is now. > In general, I'm not sure the IDE files really belong in the code repository, > but since they are there, it is better to fix them. > I don't use Eclipse, so I can't test. But if the part that is dealt with here > is confirmed to work, I suggest we merge that, and create a follow-up issue > for the missing parts (test). I don't mind either way. If we want to proceed, I'm OK with either of: 1. Accept the PR as-is and file a follow-up issue 2. Add the change proposed by @nlisker and list him as a co-contributor (in which case he can still review it). Long term, as @johanvos pointed out, it might be better to get the IDE files out of the repo, but I'll leave that entirely up to the Eclipse users to decide. There is already an issue tracking this: [JDK-8223374](https://bugs.openjdk.java.net/browse/JDK-8223374). ------------- PR: https://git.openjdk.java.net/jfx/pull/352
