On Tue, 18 Feb 2025 20:19:06 GMT, Andy Goryachev <ango...@openjdk.org> wrote:
>> Michael Strauß has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> minify button glyphs
>
> modules/javafx.graphics/src/main/java/javafx/scene/layout/HeaderBar.java line
> 341:
>
>> 339: * @param trailing the trailing node
>> 340: */
>> 341: public HeaderBar(Node leading, Node center, Node trailing) {
>
> here you refer to "leading" and "trailing", but the system insets are "left"
> and "right", why is that?
>
> When the platform goes RTL, don't the buttons flip as well? Should the
> system insets be referred to as leading/trailing?
On most platforms, the header buttons will switch sides when using RTL
orientation, but it doesn't necessarily have to do that. For example, if you
switch the layout orientation after the window has been shown, the header
buttons will stay where they are.
I'm using "leading" and "trailing" when I'm referring to JavaFX layout, which
can change at any time. On the other hand, I'm using "left" and "right" to
refer to the physical placement of window buttons, which may be different from
JavaFX layout.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1605#discussion_r1960572904
