On Thu, 17 Sep 2026 21:56:37 GMT, Ziad El Midaoui <[email protected]> 
wrote:

>> Improved the manual test instructions and pass/fail criteria for the 
>> following tests :
>> 
>> - NotResizableWindowTest
>> - DndBasic
>> - DndTestDragViewRawImage
>> - PrintDialogModalityTest
>> - PrintOrientTest
>> - StartIconified
>> - DragDropFromSwingComponentInSwingNodeTest
>> - DragDropOntoJavaFXControlInJFXPanelTest
>> - EmojiTest
>> - EventListenerLeak
>> - InputTypeAcceptAttributeTest
>> - GifImageTestApp
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Ziad El Midaoui has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Remove whitespaces.

tests/manual/dnd/DndBasic.java line 107:

> 105:             modifiers =
> 106:                     "Windows/Linux: Use 'Ctrl' for COPY, 'Shift' for 
> MOVE, " +
> 107:                             "and 'Ctrl+Shift' for LINK.";

Shouldn't "no modifier" also be tested?

tests/manual/swing/DragDropFromSwingComponentInSwingNodeTest.java line 92:

> 90:         4. Click Pass if the exact text "some string data" is inserted; 
> otherwise, click Fail.
> 91: 
> 92:         """),

Minor: the indentation is off

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2315#discussion_r4047089204
PR Review Comment: https://git.openjdk.org/jfx/pull/2315#discussion_r4047114144

Reply via email to