On Wed, 23 Sep 2026 15:39:19 GMT, Marius Hanl <[email protected]> wrote:
>> Marius Hanl has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - Move platform factory to GlassPlatform
>> - Move accessible handling to GlassPlatform
>> - Move headless, egl embedded type (now monocle) to GlassPlatform
>
> modules/javafx.base/src/main/java/com/sun/javafx/PlatformUtil.java line 171:
>
>> 169: int lastIndexOfSlash = Math.max(
>> 170: s.lastIndexOf('/'), s.lastIndexOf('\\'));
>> 171: return new File(new URI(s.substring(0, lastIndexOfSlash +
>> 1)).toURL().getPath());
>
> `new URL` was deprecated, so replaced with the recommended alternative. Can
> also revert, but since I touched the class and I thought this might be a
> good thing (+ you will probably test the offline build anyway again?).
This change seems fine to me.
> modules/javafx.graphics/src/main/java/com/sun/glass/ui/GlassPlatform.java
> line 63:
>
>> 61: IS_ACCESSIBILITY_ENABLED = Boolean.parseBoolean(override);
>> 62: } else {
>> 63: IS_ACCESSIBILITY_ENABLED = true;
>
> Before, we checked if >= Mac 10.9 and >= Windows 7. Which I think are both
> anyway our minimum supported platforms, right?
Getting rid of the OS _version_ check seems fine. However, I don't think we
should remove the OS check itself. The default value should be `true` on macOS
and Windows and `false` on Linux (and everywhere else, like Android or iOS).
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2299#discussion_r4496262495
PR Review Comment: https://git.openjdk.org/jfx/pull/2299#discussion_r4496446048
