On Wed, May 9, 2012 at 8:16 AM, Peter Stuge <[email protected]> wrote: > Andreas Fritiofson wrote: > >> I started a branch to clean it up, before I realized I needed the >> async api which made it completely unusable anyway. I don't quite >> understand the purpose of the abstraction, it's not very useful. >> If you want to use libusb-1.0 with the same API as before, there's >> always libusb-compat. > > Yes, but I think the motivation was to cut the extra dependency and > go straight to the 1.0 API. You're right that the abstraction isn't > super useful beyond that it allows OpenOCD to build with whatever > libusb API is available on the system. > > Especially for Windows this is nice, because libusb0.sys and > libusb-win32 is more flexible (0.1 API) than WinUSB.sys (1.0 API). > > >> Don't let the revert and/or fix hold off an unrelated patchset. > > Stop repeating this.
Actually it is very important to repeat this, especially to you. The libusbx fork is exactly because you want something perfect so that we got no libusb release for two years. Do not try to hold off OpenOCD release with your idea of a "perfect" release. >> Even the abstraction and the build system are separate issues. > > Yes and no. All the problems were added by a single patch. > >> the autotools support is not worse than what we've had before, >> for example for libftdi. > > That's not a reason to have bad code. You didn't push half a buggy > driver, you finished it and pushed something good. > > >> I agree that it's an ugly mess but not that it's a huge problem >> that could hold off a release. > > I expect more people to see the release than .git, and publishing a > release which potentially has *more* issues than the previous one > is stupid imo. > >> If we get a patch to fix it in time, great. > > You know just as well as I do that the only patch for this that "we" > will get will have to come from me, since noone else seems to really > care much about it. > Okay, assume this true that the patch will only come from you, in that case, how long will you need? -- Xiaofan ------------------------------------------------------------------------------ Live Security Virtual Conference Exclusive live event will cover all the ways today's security and threat landscape has changed and how IT managers can respond. Discussions will include endpoint security, mobile security and the latest in malware threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ _______________________________________________ OpenOCD-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openocd-devel
