I can verify that this patch makes the fake errors go away.

// Dean Glazeski


On Thu, Nov 19, 2009 at 8:16 PM, Zach Welch <[email protected]> wrote:

> Another whoops.  The changes to use '$_CHIPNAME.flash' were added after
> I wrote that code, and I didn't consider the consequences thoroughly.
> The attached patch should fix the issue.  Let me know, and I'll push it.
>
> --Z
>
> On Thu, 2009-11-19 at 18:01 -0600, Dean Glazeski wrote:
> > This series seems to make command.c spew errors about "invalid command
> > argument".  I traced it back to the parse##type macro or whatver that
> > is that is called from flash/common.c in the get_flash_name_index
> > function that is called from pretty much every nand * command.  For my
> > NAND devices, they don't have an integer after the '.'.  I'm not
> > really sure why this is there or how to fix it.
> >
> > // Dean Glazeski
> >
> >
> > On Thu, Nov 19, 2009 at 5:00 PM, Zach Welch <[email protected]>
> > wrote:
> >         On Wed, 2009-11-18 at 02:56 -0800, Zachary T Welch wrote:
> >         > Hi all,
> >         >
> >         > This series improves on the patch sent previously to add
> >         bank names.
> >         > It adds a 'name' field to the flash and nand bank
> >         structures.
> >         >
> >         > This name must be passed as the first argument to the 'flash
> >         bank' and
> >         > 'nand device' commands, so the last two patches update all
> >         scripts to
> >
> >         > add 'set FLASHBANK $_CHIPNAME.flash' and use the improved
> >         syntax.
> >
> >         I have pushed this series.  Anyone with their own script that
> >         uses flash
> >         or nand bank (most of them!) will notice the breakage.
> >
> >         The 'nand device' and 'flash bank' commands now take the
> >         desired name as
> >         their first argument, which has been updated using the
> >         convention above.
> >         So,
> >
> >          flash bank ...
> >
> >         effectively becomes
> >
> >          flash bank $_CHIPNAME.flash ....
> >
> >         and similarly for the 'nand device' command.  You should now
> >         be able to
> >         refer to it by this name instead of using its bank number, if
> >         you want
> >         to update your scripts (or those in the tree).
> >
> >
> >         Cheers,
> >
> >         Zach
> >         _______________________________________________
> >         Openocd-development mailing list
> >         [email protected]
> >         https://lists.berlios.de/mailman/listinfo/openocd-development
> >
> >
>
>
>
>
_______________________________________________
Openocd-development mailing list
[email protected]
https://lists.berlios.de/mailman/listinfo/openocd-development

Reply via email to