I want to point out that there is rudimentary IPv6 support in HEAD
already. Well, it depends on new DSO_global_lookup, but it's not the
point I want to emphasize.
I prepared new version of the patch.
- struct sockaddr_in server,client;
+ struct addrinfo *res, *res0, hints;
Typically unacceptable. You think exclusively about your platform and
disregard the fact that there might be platform, which don't have struct
addrinfo declared. All such changes should be *conditional*. Switching
to generic struct sockaddr complemented with #ifdef EAI_FAMILY and
#ifdef AF_INTE6 seemed to be appropriate for HEAD. Is there reason to do
something different in 098?
Then keep in mind our workflow. Functional changes go to HEAD, then and
only then possibility of backport to one or more stable branches is
considered. I personally would also allow for some time between commit
to HEAD and backport, so that some feedback can be gathered.
For reference. As for DSO_global_lookup. It might appear dubious to Unix
programmer, but it's not as uncommon in Windows, when program is
compiled with one set of headers is linked with elder system library at
run-time. That's where DSO_global_lookup is expected to fill in. Of
course one also has to double-check that corresponding structures are
compatible (which was done) and do appropriate things if not (turned to
be unnecessary in given case). So that changes can be made conditional
even at run-time... A.
______________________________________________________________________
OpenSSL Project http://www.openssl.org
Development Mailing List [email protected]
Automated List Manager [EMAIL PROTECTED]
