On 4 September 2014 16:00, Solly Ross <sr...@redhat.com> wrote: >> My only question is about the need to separate out each virt driver into a >> separate project, wouldn't you >> accomplish a lot of the benefit by creating a single virt project that >> includes all of the drivers? > > I don't think there's particularly a *point* to having all drivers in one > repo. Part of code review is looking for code "gotchas", but part of code > review is looking for subtle issues that are caused by the very nature of the > driver. A HyperV "core" reviewing a libvirt change should certainly be able > to provide the former, but most likely cannot provide the latter to a > sufficient degree (if he or she can, then he or she should be a libvirt > "core" as well).
I think that having a shared review team across all of the drivers has definite benefits in terms of coherency and consistency - it is very easy for experts on one technology to become tunnel-visioned on some points and miss the wider, cross project picture. A common drivers team is likely to have a broad enough range of opinions to keep things healthy, compared to one repo (and team) per driver, and also they are able to speak collectively to teh core nova team, which helps set priorities there when they need to be influenced on behalf of the drivers team. TLDR: I don't think there's particularly a point to splitting out the drivers into individual repos, and much to be gained from keeping them all in one (but still breaking them out of nova) _______________________________________________ OpenStack-dev mailing list OpenStackemail@example.com http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev