-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 On 12/09/14 18:00, Mike Bayer wrote: > > On Sep 12, 2014, at 11:56 AM, Johannes Erdfelt > <johan...@erdfelt.com> wrote: > >> On Fri, Sep 12, 2014, Doug Hellmann <d...@doughellmann.com> >> wrote: >>> I don’t think we will want to retroactively change the >>> migration scripts (that’s not something we generally like to >>> do), >> >> We don't allow semantic changes to migration scripts since people >> who have already run it won't get those changes. However, we >> haven't been shy about fixing bugs that prevent the migration >> script from running (which this change would probably fall >> into). > > fortunately BEGIN/ COMMIT are not semantic directives. The > migrations semantically indicated by the script are unaffected in > any way by these run-environment settings. > > >> >>> so we should look at changes needed to make sqlalchemy-migrate >>> deal with them (by ignoring them, or working around the errors, >>> or whatever). >> >> That said, I agree that sqlalchemy-migrate shouldn't be changing >> in a non-backwards compatible way. > > on the sqlalchemy-migrate side, the handling of it’s ill-conceived > “sql script” feature can be further mitigated here by parsing for > the “COMMIT” line when it breaks out the SQL and ignoring it, I’d > favor that it emits a warning also.
I went on with ignoring COMMIT specifically in SQL scripts: https://review.openstack.org/#/c/121517/ Though we could also ignore other transaction managing statements in those scripts, like ROLLBACK, they are highly unlikely to occur in migration code, so I ignore them in the patch. /Ihar -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.22 (Darwin) iQEcBAEBCgAGBQJUFtXpAAoJEC5aWaUY1u57++gIAJb8JdVm5Du/6D9o18QRvH9S vZYtXWbI3637f0bII7rTwMVc5AK3m9s6q1WVuCiNZiFdMhI7YApU2qaC3KGMcxo7 3x+R1ptgbslR9rJj0T8ohMPX4pOVd2Wd0keqNw8plytduaT3tNK6J7Lvc/wqDWkS BDpIw6p5XWPMqbWzDdkPjIqK7rG6/bqZO8LXDsD1l/l4QjlzXB/qxyW5hFiR/ANe iAhEAfAmDLRQMs5DFHc6UNaOoh+DjODq7V4hMSQJtwC8x6RmW0mAbBg+Ii21dugD lqM53C9nIHmGP84jDjKy0W3aLeY0Z0m8ulUNCfGjKWZjy1ng5gRU9voxVse3Xfs= =Vt8X -----END PGP SIGNATURE----- _______________________________________________ OpenStack-dev mailing list OpenStackemail@example.com http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev