Attention is currently required from: flichtenheld, stipa. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/803?usp=email )
Change subject: Add methods to read/write packet ids for epoch data ...................................................................... Patch Set 5: (1 comment) File src/openvpn/packet_id.c: http://gerrit.openvpn.net/c/openvpn/+/803/comment/feb6ca8b_77e908f0 : PS5, Line 667: pin->id = id & 0xffffffffffffull; > shouldn't we use PACKET_ID_EPOCH_MAX here? yes, will fix that. Technically it is a mask here but the mask is identical. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/803?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I2a104decdb1e77a460f7a6976bcd0560b67a07b5 Gerrit-Change-Number: 803 Gerrit-PatchSet: 5 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-CC: stipa <lstipa...@gmail.com> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: stipa <lstipa...@gmail.com> Gerrit-Comment-Date: Sat, 30 Nov 2024 13:06:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: stipa <lstipa...@gmail.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
