Attention is currently required from: flichtenheld, plaisthos, stipa. MaxF has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/803?usp=email )
Change subject: Add methods to read/write packet ids for epoch data ...................................................................... Patch Set 8: (5 comments) Patchset: PS8: Nitpicks about comments, code looks good to me. File src/openvpn/packet_id.h: http://gerrit.openvpn.net/c/openvpn/+/803/comment/c836da37_30744229 : PS8, Line 49: Maks Mask http://gerrit.openvpn.net/c/openvpn/+/803/comment/ecbf03a7_cb2058dd : PS8, Line 331: packed I'm thinking this is a typo. Or is it actually a packed struct? http://gerrit.openvpn.net/c/openvpn/+/803/comment/8101af1b_44e6d50f : PS8, Line 333: epcoh epoch File tests/unit_tests/openvpn/test_packet_id.c: http://gerrit.openvpn.net/c/openvpn/+/803/comment/230d5a2f_40d775b3 : PS8, Line 241: /* test writing/checking the 48 bit overflow */ I don't get it, what overflow? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/803?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I2a104decdb1e77a460f7a6976bcd0560b67a07b5 Gerrit-Change-Number: 803 Gerrit-PatchSet: 8 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: MaxF <m...@max-fillinger.net> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-CC: stipa <lstipa...@gmail.com> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: stipa <lstipa...@gmail.com> Gerrit-Comment-Date: Fri, 27 Dec 2024 18:32:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
