Attention is currently required from: plaisthos, stipa. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/803?usp=email )
Change subject: Add methods to read/write packet ids for epoch data ...................................................................... Patch Set 8: Code-Review-1 (3 comments) File src/openvpn/packet_id.h: http://gerrit.openvpn.net/c/openvpn/+/803/comment/1049acea_ac1fd539 : PS8, Line 49: /** Maks of the bits that make out the epoch in the packet counter */ "Maks" -> "Mask". "make out" -> "masks out"? http://gerrit.openvpn.net/c/openvpn/+/803/comment/8ca67c36_92924ef3 : PS8, Line 333: * @param buf buffer to write the packet id/epcoh to "epoch" File src/openvpn/packet_id.c: http://gerrit.openvpn.net/c/openvpn/+/803/comment/7a433205_650c3d7a : PS8, Line 684: * integer contain our counter but the upper two bytes are always 0 */ This is confusing. The point where we convert to network order the epoch is already joined, so the bytes aren't 0, are they? -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/803?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I2a104decdb1e77a460f7a6976bcd0560b67a07b5 Gerrit-Change-Number: 803 Gerrit-PatchSet: 8 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-CC: stipa <lstipa...@gmail.com> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: stipa <lstipa...@gmail.com> Gerrit-Comment-Date: Fri, 27 Dec 2024 16:25:24 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
