Attention is currently required from: flichtenheld, stipa.

plaisthos has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/803?usp=email )

Change subject: Add methods to read/write packet ids for epoch data
......................................................................


Patch Set 8:

(3 comments)

File src/openvpn/packet_id.h:

http://gerrit.openvpn.net/c/openvpn/+/803/comment/f34723d4_5781004e :
PS8, Line 49: /** Maks of the bits that make out the epoch in the packet 
counter */
> "Maks" -> "Mask". […]
Done


http://gerrit.openvpn.net/c/openvpn/+/803/comment/6fc94b17_3cb2fa5b :
PS8, Line 333:  * @param buf       buffer to write the packet id/epcoh to
> "epoch"
Done


File src/openvpn/packet_id.c:

http://gerrit.openvpn.net/c/openvpn/+/803/comment/3a7675bb_c3f00413 :
PS8, Line 684:      * integer contain our counter but the upper two bytes are 
always 0 */
> This is confusing. […]
Done



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/803?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I2a104decdb1e77a460f7a6976bcd0560b67a07b5
Gerrit-Change-Number: 803
Gerrit-PatchSet: 8
Gerrit-Owner: plaisthos <arne-open...@rfc2549.org>
Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-CC: stipa <lstipa...@gmail.com>
Gerrit-Attention: flichtenheld <fr...@lichtenheld.com>
Gerrit-Attention: stipa <lstipa...@gmail.com>
Gerrit-Comment-Date: Fri, 27 Dec 2024 18:17:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com>
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to