Attention is currently required from: MaxF, flichtenheld, stipa. plaisthos has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/803?usp=email )
Change subject: Add methods to read/write packet ids for epoch data ...................................................................... Patch Set 10: (2 comments) File src/openvpn/packet_id.h: http://gerrit.openvpn.net/c/openvpn/+/803/comment/d417abd6_3a14c47d : PS8, Line 331: packed > I'm thinking this is a typo. […] typo. Will fix. File tests/unit_tests/openvpn/test_packet_id.c: http://gerrit.openvpn.net/c/openvpn/+/803/comment/9930dda9_9f758def : PS8, Line 241: /* test writing/checking the 48 bit overflow */ > I don't get it, what overflow? Epoch packet counter is max 48 bit. This is 2**48-1. Will extend the comment. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/803?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I2a104decdb1e77a460f7a6976bcd0560b67a07b5 Gerrit-Change-Number: 803 Gerrit-PatchSet: 10 Gerrit-Owner: plaisthos <arne-open...@rfc2549.org> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-CC: MaxF <m...@max-fillinger.net> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-CC: stipa <lstipa...@gmail.com> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: stipa <lstipa...@gmail.com> Gerrit-Attention: MaxF <m...@max-fillinger.net> Gerrit-Comment-Date: Sat, 04 Jan 2025 22:49:22 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: MaxF <m...@max-fillinger.net> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
