Attention is currently required from: cron2, flichtenheld, plaisthos. mattock has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/811?usp=email )
Change subject: Add lwip support to t_server_null ...................................................................... Patch Set 9: (2 comments) File tests/t_server_null_client.sh: http://gerrit.openvpn.net/c/openvpn/+/811/comment/20dab47b_dd38af2d : PS8, Line 138: server_pid=$(cat "$i.pid" 2> /dev/null) > this looks like an unrelated change... […] Yes, that seems to be the case. I recall the extra "tr" was required on one of the BSDs which added whitespace before or after "wc -w" output. Why it worked before (or maybe it did not?) I do not know. The latter part was probably just me fixing a small inconsistency when I saw it. Both can be split into a separate, trivial patch if we want. http://gerrit.openvpn.net/c/openvpn/+/811/comment/c6b7e77a_aaf98854 : PS8, Line 173: $RUN_SUDO rm -f ./*.ips > running `sudo rm -f` gives me the creeps, tbh, though I see no obvious way > this could explode (today […] I believe you're correct. If RUN_SUDO was needed for some corner-case I would probably have added a comment explaining that. I removed RUN_SUDO and ran the code through Buildbot and manually on FreeBSD 14 and NetBSD 10. It still behaved as one would expect. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/811?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ie63f302402f469c3aa48ac146ca6b8c029f0d250 Gerrit-Change-Number: 811 Gerrit-PatchSet: 9 Gerrit-Owner: mattock <sam...@openvpn.net> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: cron2 <g...@greenie.muc.de> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Comment-Date: Wed, 22 Jan 2025 15:20:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 <g...@greenie.muc.de> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
