Attention is currently required from: mattock, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/811?usp=email )
Change subject: Add lwip support to t_server_null ...................................................................... Patch Set 8: (2 comments) File tests/t_server_null_client.sh: http://gerrit.openvpn.net/c/openvpn/+/811/comment/5bcb7010_986383b7 : PS8, Line 138: server_pid=$(cat "$i.pid" 2> /dev/null) this looks like an unrelated change...? http://gerrit.openvpn.net/c/openvpn/+/811/comment/0527ab4d_5f6a61dd : PS8, Line 173: $RUN_SUDO rm -f ./*.ips running `sudo rm -f` gives me the creeps, tbh, though I see no obvious way this could explode (today). `sudo` is not needed here, anyway, as we have write access to the directory so we can remove whatever files there are. `-f` is needed (because non-writeable files might otherwise make rm start asking). -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/811?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ie63f302402f469c3aa48ac146ca6b8c029f0d250 Gerrit-Change-Number: 811 Gerrit-PatchSet: 8 Gerrit-Owner: mattock <sam...@openvpn.net> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: mattock <sam...@openvpn.net> Gerrit-Comment-Date: Thu, 09 Jan 2025 15:00:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
