Attention is currently required from: mattock, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/811?usp=email )
Change subject: Add lwip support to t_server_null ...................................................................... Patch Set 8: Code-Review-1 (1 comment) Patchset: PS8: What is the point of backgrounding stuff from an `--up` script that waits on an (unrelated) foreground process to then kill the openvpn process from within the script? This looks very... weird, also `ps axwu |grep fping` is a very good way to find arbitrary processes running on the system, but not *your* fping. The `--up` script should do what an up script does well - save the IP address. The `wait for fping to terminate` already happens, by nature of a synchronous call, in `ping_lwip_clients()` - so killing the processes should be done from there, when the *correct* fping test is done. There's more comments inline... -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/811?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ie63f302402f469c3aa48ac146ca6b8c029f0d250 Gerrit-Change-Number: 811 Gerrit-PatchSet: 8 Gerrit-Owner: mattock <sam...@openvpn.net> Gerrit-Reviewer: cron2 <g...@greenie.muc.de> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: mattock <sam...@openvpn.net> Gerrit-Comment-Date: Thu, 09 Jan 2025 14:56:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
