Attention is currently required from: d12fk, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/838?usp=email )
Change subject: dns: apply settings via script on unixoid systems ...................................................................... Patch Set 12: Code-Review-1 (7 comments) Patchset: PS12: Documentation still not quite right... File doc/man-sections/script-options.rst: http://gerrit.openvpn.net/c/openvpn/+/838/comment/a70abe1d_54f8b426 : PS12, Line 246: script No, this doesn't work. rst is very specific here, only one argument is allowed. Which is why we do the weird "args" "Valid syntaxes" dance for many options. I specifically only asked you to put the `| disable` in the usage text, not here. http://gerrit.openvpn.net/c/openvpn/+/838/comment/44abd65b_de60dd5a : PS12, Line 253: on "in the order" http://gerrit.openvpn.net/c/openvpn/+/838/comment/7490ff27_e8edc43e : PS12, Line 258: option `` `s `` does not work. `` `'s `` seems to work. http://gerrit.openvpn.net/c/openvpn/+/838/comment/794ec9d2_6cd36626 : PS12, Line 259: option same http://gerrit.openvpn.net/c/openvpn/+/838/comment/15d13f22_008f6f3d : PS12, Line 261: ``--up`` and ``--down`` hooks for backward compatibility. I think it is "backward*s* compatibility" File src/openvpn/options.c: http://gerrit.openvpn.net/c/openvpn/+/838/comment/be2e97aa_62e6de9d : PS12, Line 531: "--dns-script cmd : Run cmd as user defined dns configuration script\n" Add the `|disable` here -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/838?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: Ifbe4ffb44d3bfcaa50adb38cacb3436fcdc71b10 Gerrit-Change-Number: 838 Gerrit-PatchSet: 12 Gerrit-Owner: d12fk <he...@openvpn.net> Gerrit-Reviewer: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: d12fk <he...@openvpn.net> Gerrit-Comment-Date: Fri, 07 Mar 2025 10:37:11 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
