Attention is currently required from: ordex, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/791?usp=email )
Change subject: Reformat the whole project with clang-format ...................................................................... Patch Set 14: (6 comments) File sample/sample-plugins/client-connect/sample-client-connect.c: http://gerrit.openvpn.net/c/openvpn/+/791/comment/1bf6c87b_4e6169ab : PS14, Line 135: stderr, > this hurts me a bit, for two reasons: […] Not quite sure why it doesn't align to "(", it does for almost all other occurences. I think it might have a trade-off here between trying to align and trying to get the string in the colum limit. http://gerrit.openvpn.net/c/openvpn/+/791/comment/4cf494a4_79f7b8ce : PS14, Line 251: MODULE, > same as above, I expected MODULE to be on the line above […] So basically what you want is "BinPackArguments: true", will apply that. http://gerrit.openvpn.net/c/openvpn/+/791/comment/d9dba330_b8c72914 : PS14, Line 252: "env has UV_WANT_CC_ASYNC=%d, but " > here there is a more generic question to answer: do we want to keep string on > the same line, even if […] Has nothing to do with this patch though, AFAICT File sample/sample-plugins/defer/multi-auth.c: http://gerrit.openvpn.net/c/openvpn/+/791/comment/8b72fd16_d619cd73 : PS14, Line 294: const char *envp[]) > ratio behind this change? one arg per line? yes. This is BinPackParameters. Do you also want that set to "true"? http://gerrit.openvpn.net/c/openvpn/+/791/comment/d94e4661_457ff043 : PS14, Line 418: plog(context, PLOG_NOTE, "FUNC: openvpn_plugin_client_constructor_v1"); > how about forcing a new line after variables declaration? Doesn't seem to be supported. There is a feature request for it: https://github.com/llvm/llvm-project/issues/97303 File sample/sample-plugins/log/log_v3.c: http://gerrit.openvpn.net/c/openvpn/+/791/comment/c9c800e4_6ecdeccd : PS14, Line 87: "log_v3: ** ERROR ** Incompatible plug-in interface between this plug-in and OpenVPN\n"); > this is probably another instance of the same situation as before. yes -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/791?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I2566ad493629e1f5fdfa6f6483b8973463404e3e Gerrit-Change-Number: 791 Gerrit-PatchSet: 14 Gerrit-Owner: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-CC: ordex <anto...@mandelbit.com> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: ordex <anto...@mandelbit.com> Gerrit-Comment-Date: Wed, 16 Apr 2025 11:47:43 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: ordex <anto...@mandelbit.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
