Attention is currently required from: ordex, plaisthos.

flichtenheld has posted comments on this change. ( 
http://gerrit.openvpn.net/c/openvpn/+/791?usp=email )

Change subject: Reformat the whole project with clang-format
......................................................................


Patch Set 16:

(1 comment)

File sample/sample-plugins/defer/multi-auth.c:

http://gerrit.openvpn.net/c/openvpn/+/791/comment/d4a601b3_b1efe856 :
PS14, Line 294:                       const char *envp[])
> I think we should. […]
I disagree. Note that when setting BinPackParameters to true this will apply to 
all functions and all parameters. I think in general if the parameters to do 
fit on one line, it is better to put them one per line. Let's see what others 
think.



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/791?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings

Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I2566ad493629e1f5fdfa6f6483b8973463404e3e
Gerrit-Change-Number: 791
Gerrit-PatchSet: 16
Gerrit-Owner: flichtenheld <fr...@lichtenheld.com>
Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org>
Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net>
Gerrit-CC: ordex <anto...@mandelbit.com>
Gerrit-Attention: plaisthos <arne-open...@rfc2549.org>
Gerrit-Attention: ordex <anto...@mandelbit.com>
Gerrit-Comment-Date: Wed, 16 Apr 2025 13:55:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com>
Comment-In-Reply-To: ordex <anto...@mandelbit.com>
Gerrit-MessageType: comment
_______________________________________________
Openvpn-devel mailing list
Openvpn-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to