Attention is currently required from: cron2, ordex, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/791?usp=email )
Change subject: Reformat the whole project with clang-format ...................................................................... Patch Set 19: (4 comments) File src/openvpn/buffer.c: http://gerrit.openvpn.net/c/openvpn/+/791/comment/5fa573c3_de511cf1 : PS18, Line 850: } while (c); > Why? As discussed on IRC this is actually correct for our current formatting. http://gerrit.openvpn.net/c/openvpn/+/791/comment/5173a895_ec42235c : PS18, Line 915: && c != 127)) /* allow ascii non-control and UTF-8, consider DEL to be a control */ > Yes. Done in separate commit. File src/openvpn/comp.h: http://gerrit.openvpn.net/c/openvpn/+/791/comment/ca6252bf_a8b50dfe : PS18, Line 93: bool check_compression_settings_valid(struct compress_options *info, int msglevel); > this is one of the changes I'm not sure we want - having the return type on > the line before gives us […] As discussed in IRC this is consistent with what we have. Switched the .clang-format to use "AllDefinitions" instead which doesn't change anything but better matches our policy. File src/openvpn/console_builtin.c: http://gerrit.openvpn.net/c/openvpn/+/791/comment/9b83c0b1_41c7cd5f : PS18, Line 74: msg(M_WARN | M_ERRNO, "get_console_input_win32(): unexpected error"); > Interestingly one of the things we can't configure in clang-format. […] Done -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/791?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I2566ad493629e1f5fdfa6f6483b8973463404e3e Gerrit-Change-Number: 791 Gerrit-PatchSet: 19 Gerrit-Owner: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: cron2 <g...@greenie.muc.de> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-CC: ordex <anto...@mandelbit.com> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: cron2 <g...@greenie.muc.de> Gerrit-Attention: ordex <anto...@mandelbit.com> Gerrit-Comment-Date: Mon, 26 May 2025 10:40:42 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: cron2 <g...@greenie.muc.de> Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
