Attention is currently required from: flichtenheld, ordex, plaisthos. cron2 has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/791?usp=email )
Change subject: Reformat the whole project with clang-format ...................................................................... Patch Set 18: (5 comments) Patchset: PS18: Overall this is impressively good. Some changes (struct opening bracket) should have been done all along :-) - others just make sense. I have a few that I do not like and I think one actual bug in the ruleset (`do...while()` in buffer.c). File src/openvpn/buffer.c: http://gerrit.openvpn.net/c/openvpn/+/791/comment/e228108e_a877cddf : PS18, Line 850: } while (c); it should not do that http://gerrit.openvpn.net/c/openvpn/+/791/comment/450ac52e_57fa1b4a : PS18, Line 915: && c != 127)) /* allow ascii non-control and UTF-8, consider DEL to be a control */ this is ugly, but I guess the best way to fix it is to manually move the comment before the if() line File src/openvpn/comp.h: http://gerrit.openvpn.net/c/openvpn/+/791/comment/07c11cf5_a35c47d6 : PS18, Line 93: bool check_compression_settings_valid(struct compress_options *info, int msglevel); this is one of the changes I'm not sure we want - having the return type on the line before gives us more line length for the actual prototype, and also it eases "grep ^function" to find prototype + function implementation (my use case, which I could certainly solve differently) File src/openvpn/console_builtin.c: http://gerrit.openvpn.net/c/openvpn/+/791/comment/ecc1640a_115b4d7b : PS18, Line 74: msg(M_WARN | M_ERRNO, "get_console_input_win32(): unexpected error"); the extra spaces around `foo|bar` are not really to my liking ("this belongs together" vibes) -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/791?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I2566ad493629e1f5fdfa6f6483b8973463404e3e Gerrit-Change-Number: 791 Gerrit-PatchSet: 18 Gerrit-Owner: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: cron2 <g...@greenie.muc.de> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-CC: ordex <anto...@mandelbit.com> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: flichtenheld <fr...@lichtenheld.com> Gerrit-Attention: ordex <anto...@mandelbit.com> Gerrit-Comment-Date: Sat, 24 May 2025 14:14:08 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel
