Attention is currently required from: ordex, plaisthos. flichtenheld has posted comments on this change. ( http://gerrit.openvpn.net/c/openvpn/+/791?usp=email )
Change subject: Reformat the whole project with clang-format ...................................................................... Patch Set 16: (4 comments) File sample/sample-plugins/client-connect/sample-client-connect.c: http://gerrit.openvpn.net/c/openvpn/+/791/comment/763d178b_37f47877 : PS14, Line 251: MODULE, > So basically what you want is "BinPackArguments: true", will apply that. Done File sample/sample-plugins/defer/multi-auth.c: http://gerrit.openvpn.net/c/openvpn/+/791/comment/e720aaa5_9dff2c4a : PS14, Line 267: np(context->test_valid_user), > I'd vote for putting these arguments on the same line, if there is enough > space. Done http://gerrit.openvpn.net/c/openvpn/+/791/comment/6d71e7fc_faa3fc2d : PS14, Line 418: plog(context, PLOG_NOTE, "FUNC: openvpn_plugin_client_constructor_v1"); > Doesn't seem to be supported. There is a feature request for it: > https://github. […] Acknowledged File sample/sample-plugins/log/log_v3.c: http://gerrit.openvpn.net/c/openvpn/+/791/comment/5a59375c_600cff63 : PS14, Line 87: "log_v3: ** ERROR ** Incompatible plug-in interface between this plug-in and OpenVPN\n"); > yes Acknowledged -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/791?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I2566ad493629e1f5fdfa6f6483b8973463404e3e Gerrit-Change-Number: 791 Gerrit-PatchSet: 16 Gerrit-Owner: flichtenheld <fr...@lichtenheld.com> Gerrit-Reviewer: plaisthos <arne-open...@rfc2549.org> Gerrit-CC: openvpn-devel <openvpn-devel@lists.sourceforge.net> Gerrit-CC: ordex <anto...@mandelbit.com> Gerrit-Attention: plaisthos <arne-open...@rfc2549.org> Gerrit-Attention: ordex <anto...@mandelbit.com> Gerrit-Comment-Date: Wed, 16 Apr 2025 13:48:29 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: flichtenheld <fr...@lichtenheld.com> Comment-In-Reply-To: ordex <anto...@mandelbit.com> Gerrit-MessageType: comment
_______________________________________________ Openvpn-devel mailing list Openvpn-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/openvpn-devel