Attention is currently required from: cron2, flichtenheld, plaisthos.

razvanc has posted comments on this change by plaisthos. ( 
http://gerrit.openvpn.net/c/openvpn/+/890?usp=email )

Change subject: Always use a 0.0.0.0/0 default on Android instead of def1
......................................................................


Patch Set 2: Code-Review-1

(2 comments)

Commit Message:

http://gerrit.openvpn.net/c/openvpn/+/890/comment/6387bb4f_95487c56?usp=email :
PS2, Line 9: Certain handset manufactures (like Samsung iirc)  are handling
Typo: "manufacturers".


File src/openvpn/options.c:

http://gerrit.openvpn.net/c/openvpn/+/890/comment/0fa6af79_24687b35?usp=email :
PS2, Line 7325:                 options->routes->flags |= RG_DEF1;
I hope I've followed the core correctly, but `do_init_route_ipv6_list()` still 
seems to unconditionally install specific routes. Do we not care about IPv6, or 
is that intended?



--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/890?usp=email
To unsubscribe, or for help writing mail filters, visit 
http://gerrit.openvpn.net/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I22e4b73e744c765a43bdb29f6e18813d103ea757
Gerrit-Change-Number: 890
Gerrit-PatchSet: 2
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: cron2 <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: razvanc <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: cron2 <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
Gerrit-Comment-Date: Thu, 17 Sep 2026 14:12:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

Reply via email to