Gert Doering has submitted this change. ( https://gerrit.openvpn.net/c/openvpn/+/890?usp=email )
Change subject: Always use a 0.0.0.0/0 default on Android instead of def1 ...................................................................... Always use a 0.0.0.0/0 default on Android instead of def1 Certain handset manufacturers (like Samsung iirc) are handling 0.0.0.0/0 different from the split /1 routes, so push the 0.0.0.0/0 route to the OS. Change-Id: I22e4b73e744c765a43bdb29f6e18813d103ea757 Signed-off-by: Arne Schwabe <[email protected]> Acked-by: Gert Doering <[email protected]> Gerrit URL: https://gerrit.openvpn.net/c/openvpn/+/890 Message-Id: <[email protected]> URL: https://www.mail-archive.com/[email protected]/msg39688.html Signed-off-by: Gert Doering <[email protected]> --- M src/openvpn/options.c 1 file changed, 7 insertions(+), 0 deletions(-) diff --git a/src/openvpn/options.c b/src/openvpn/options.c index 3316053..5d10390 100644 --- a/src/openvpn/options.c +++ b/src/openvpn/options.c @@ -5625,7 +5625,14 @@ } else if (streq(p[j], "def1")) { +#ifndef TARGET_ANDROID + /* The hack that def1 uses to split 0.0.0.0 into 0.0.0.0/1 and + * 128.0.0.0/1 is not needed on Android and will even + * make some Android implementations (e.g. Samsung) + * misbehave, so silently ignore the flag and always use + * 0.0.0.0/0 instead */ options->routes->flags |= RG_DEF1; +#endif } else if (streq(p[j], "bypass-dhcp")) { -- To view, visit https://gerrit.openvpn.net/c/openvpn/+/890?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I22e4b73e744c765a43bdb29f6e18813d103ea757 Gerrit-Change-Number: 890 Gerrit-PatchSet: 4 Gerrit-Owner: plaisthos <[email protected]> Gerrit-Reviewer: Frank Lichtenheld <[email protected]> Gerrit-Reviewer: Gert Doering <[email protected]> Gerrit-Reviewer: Răzvan Cojocaru <[email protected]> Gerrit-CC: openvpn-devel <[email protected]>
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
