Attention is currently required from: cron2, flichtenheld, plaisthos, razvanc.
Hello cron2, flichtenheld, razvanc,
I'd like you to reexamine a change. Please visit
http://gerrit.openvpn.net/c/openvpn/+/890?usp=email
to look at the new patch set (#3).
The following approvals got outdated and were removed:
Code-Review-1 by razvanc
Change subject: Always use a 0.0.0.0/0 default on Android instead of def1
......................................................................
Always use a 0.0.0.0/0 default on Android instead of def1
Certain handset manufacturers (like Samsung iirc) are handling
0.0.0.0/0 different from the split /1 routes, so push the 0.0.0.0/0
route to the OS.
Change-Id: I22e4b73e744c765a43bdb29f6e18813d103ea757
Signed-off-by: Arne Schwabe <[email protected]>
---
M src/openvpn/options.c
1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://gerrit.openvpn.net:29418/openvpn refs/changes/90/890/3
diff --git a/src/openvpn/options.c b/src/openvpn/options.c
index e3cd527..cbada6f 100644
--- a/src/openvpn/options.c
+++ b/src/openvpn/options.c
@@ -5615,7 +5615,14 @@
}
else if (streq(p[j], "def1"))
{
+#ifndef TARGET_ANDROID
+ /* The hack that def1 uses to split 0.0.0.0 into 0.0.0.0/1 and
+ * 128.0.0.0/1 is not needed on Android and will even
+ * make some Android implementations (e.g. Samsung)
+ * misbehave, so silently ignore the flag and always use
+ * 0.0.0.0/0 instead */
options->routes->flags |= RG_DEF1;
+#endif
}
else if (streq(p[j], "bypass-dhcp"))
{
--
To view, visit http://gerrit.openvpn.net/c/openvpn/+/890?usp=email
To unsubscribe, or for help writing mail filters, visit
http://gerrit.openvpn.net/settings?usp=email
Gerrit-MessageType: newpatchset
Gerrit-Project: openvpn
Gerrit-Branch: master
Gerrit-Change-Id: I22e4b73e744c765a43bdb29f6e18813d103ea757
Gerrit-Change-Number: 890
Gerrit-PatchSet: 3
Gerrit-Owner: plaisthos <[email protected]>
Gerrit-Reviewer: cron2 <[email protected]>
Gerrit-Reviewer: flichtenheld <[email protected]>
Gerrit-Reviewer: razvanc <[email protected]>
Gerrit-CC: openvpn-devel <[email protected]>
Gerrit-Attention: razvanc <[email protected]>
Gerrit-Attention: plaisthos <[email protected]>
Gerrit-Attention: cron2 <[email protected]>
Gerrit-Attention: flichtenheld <[email protected]>
_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel
