Attention is currently required from: plaisthos, razvanc. chugly has posted comments on this change by chugly. ( http://gerrit.openvpn.net/c/openvpn/+/1946?usp=email )
Change subject: tests: add unit tests for route.c ...................................................................... Patch Set 3: (1 comment) File CMakeLists.txt: http://gerrit.openvpn.net/c/openvpn/+/1946/comment/15ae40d6_e06c28ec?usp=email : PS3, Line 912: target_sources(test_socket PRIVATE Done in PS3, though not quite the way test_misc does it. test_networking is not a cmocka driver: it has a main() that dispatches on argv and t_net.sh drives it by test number, so there is no CMUnitTest list to add to. The route tests are a numbered case instead, case 9, which runs cmocka_run_group_tests. t_net.sh runs the cases above LAST_AUTO_TEST after it has torn down its dummy interface, so bumping LAST_TEST to 9 gets them run there without needing an interface or any particular network state. They still run on their own, networking_testdriver 9, since they need no privileges. This also drops the separate gating Razvan asked for on PS1, because networking_testdriver is already restricted to HAVE_SITNL and to Linux in CMake. -- To view, visit http://gerrit.openvpn.net/c/openvpn/+/1946?usp=email To unsubscribe, or for help writing mail filters, visit http://gerrit.openvpn.net/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: openvpn Gerrit-Branch: master Gerrit-Change-Id: I9085c55a7efefd31839b00ec8ec9a6f085574dde Gerrit-Change-Number: 1946 Gerrit-PatchSet: 3 Gerrit-Owner: chugly <[email protected]> Gerrit-Reviewer: plaisthos <[email protected]> Gerrit-Reviewer: razvanc <[email protected]> Gerrit-CC: openvpn-devel <[email protected]> Gerrit-Attention: razvanc <[email protected]> Gerrit-Attention: plaisthos <[email protected]> Gerrit-Comment-Date: Mon, 28 Sep 2026 07:41:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
_______________________________________________ Openvpn-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/openvpn-devel
